FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 2.0.1

Threshold is medium

Effort is min

Summary

ClassesBugsErrorsMissing Classes
1336401

Files

ClassBugs
org.deegree.tools.binding.CityGMLImporterGenerator1
org.deegree.tools.crs.georeferencing.application.Controller2
org.deegree.tools.crs.georeferencing.application.Scene2DValues2
org.deegree.tools.crs.georeferencing.application.handler.FileInputHandler3
org.deegree.tools.crs.georeferencing.application.handler.FileOutputHandler1
org.deegree.tools.crs.georeferencing.application.listeners.ButtonListener3
org.deegree.tools.crs.georeferencing.application.listeners.FootprintMouseListener1
org.deegree.tools.crs.georeferencing.application.listeners.NavigationTreeSelectionListener1
org.deegree.tools.crs.georeferencing.application.listeners.Scene2DMouseMotionListener1
org.deegree.tools.crs.georeferencing.application.transformation.AbstractTransformation1
org.deegree.tools.crs.georeferencing.application.transformation.Polynomial3
org.deegree.tools.crs.georeferencing.communication.PointTableFrame1
org.deegree.tools.crs.georeferencing.communication.dialog.AbstractGRDialog2
org.deegree.tools.crs.georeferencing.communication.dialog.coordinatejump.CoordinateJumperTextfieldDialog2
org.deegree.tools.crs.georeferencing.communication.dialog.error.ErrorDialog1
org.deegree.tools.crs.georeferencing.communication.panel2D.AbstractPanel2D1
org.deegree.tools.crs.georeferencing.communication.panel2D.BuildingFootprintPanel1
org.deegree.tools.crs.georeferencing.model.buttons.ToggleButtonModel1
org.deegree.tools.i18n.Messages4
org.deegree.tools.rendering.FlightControls1
org.deegree.tools.rendering.InteractiveWPVS2
org.deegree.tools.rendering.dem.builder.DEMDatasetGenerator1
org.deegree.tools.rendering.dem.builder.FileBlob1
org.deegree.tools.rendering.dem.builder.MacroTriangle1
org.deegree.tools.rendering.dem.builder.dag.DAGBuilder3
org.deegree.tools.rendering.dem.builder.dag.DAGBuilder$DAGLevel2
org.deegree.tools.rendering.dem.filtering.DEMRasterFilterer1
org.deegree.tools.rendering.dem.filtering.DEMRasterFilterer$FilteredResultWiter1
org.deegree.tools.rendering.dem.filtering.DEMRasterFilterer$RasterComparator1
org.deegree.tools.rendering.dem.filtering.DEMRasterFilterer$RasterFilterer1
org.deegree.tools.rendering.dem.filtering.filters.SmoothingFilter1
org.deegree.tools.rendering.manager.DataManager2
org.deegree.tools.rendering.manager.buildings.generalisation.WorldObjectSimplifier$RegressionForm1
org.deegree.tools.rendering.manager.buildings.importers.VRMLImporter2
org.deegree.tools.rendering.manager.stage.StageManager5
org.deegree.tools.rendering.manager.trees.TreeManager1
org.deegree.tools.rendering.viewer.Export3DFile3
org.deegree.tools.rendering.viewer.File3dExporter1
org.deegree.tools.rendering.viewer.File3dImporter1

org.deegree.tools.binding.CityGMLImporterGenerator

BugCategoryDetailsLinePriority
Found reliance on default encoding in org.deegree.tools.binding.CityGMLImporterGenerator.writeNewFile(File, ModelClass, HashMap): new java.io.FileWriter(File)I18NDM_DEFAULT_ENCODING205High

org.deegree.tools.crs.georeferencing.application.Controller

BugCategoryDetailsLinePriority
Write to static field org.deegree.tools.crs.georeferencing.communication.panel2D.AbstractPanel2D.selectedPointSize from instance method new org.deegree.tools.crs.georeferencing.application.Controller(GRViewerGUI, ApplicationState)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD99High
Write to static field org.deegree.tools.crs.georeferencing.communication.panel2D.AbstractPanel2D.zoomValue from instance method new org.deegree.tools.crs.georeferencing.application.Controller(GRViewerGUI, ApplicationState)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD100High

org.deegree.tools.crs.georeferencing.application.Scene2DValues

BugCategoryDetailsLinePriority
Primitive value is boxed then unboxed to perform primitive coercion in org.deegree.tools.crs.georeferencing.application.Scene2DValues.getPixelCoord(AbstractGRPoint)PERFORMANCEBX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION210Medium
Unwritten field: org.deegree.tools.crs.georeferencing.application.Scene2DValues.selectedLayersCORRECTNESSUWF_UNWRITTEN_FIELD634Medium

org.deegree.tools.crs.georeferencing.application.handler.FileInputHandler

BugCategoryDetailsLinePriority
Found reliance on default encoding in new org.deegree.tools.crs.georeferencing.application.handler.FileInputHandler(PointTableFrame): new java.io.FileReader(String)I18NDM_DEFAULT_ENCODING79High
Null passed for nonnull parameter of new java.io.BufferedReader(Reader) in new org.deegree.tools.crs.georeferencing.application.handler.FileInputHandler(PointTableFrame)CORRECTNESSNP_NULL_PARAM_DEREF84Medium
new org.deegree.tools.crs.georeferencing.application.handler.FileInputHandler(PointTableFrame) may fail to close streamBAD_PRACTICEOS_OPEN_STREAM84Medium

org.deegree.tools.crs.georeferencing.application.handler.FileOutputHandler

BugCategoryDetailsLinePriority
Found reliance on default encoding in new org.deegree.tools.crs.georeferencing.application.handler.FileOutputHandler(PointTableFrame): new java.io.FileWriter(String)I18NDM_DEFAULT_ENCODING77High

org.deegree.tools.crs.georeferencing.application.listeners.ButtonListener

BugCategoryDetailsLinePriority
org.deegree.tools.crs.georeferencing.application.listeners.ButtonListener.actionPerformed(ActionEvent) invokes System.exit(...), which shuts down the entire virtual machineBAD_PRACTICEDM_EXIT291Medium
Write to static field org.deegree.tools.crs.georeferencing.communication.panel2D.AbstractPanel2D.selectedPointSize from instance method org.deegree.tools.crs.georeferencing.application.listeners.ButtonListener.actionPerformed(ActionEvent)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD157High
Write to static field org.deegree.tools.crs.georeferencing.application.listeners.ButtonListener.colorIndex from instance method org.deegree.tools.crs.georeferencing.application.listeners.ButtonListener.actionPerformed(ActionEvent)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD395Medium

org.deegree.tools.crs.georeferencing.application.listeners.FootprintMouseListener

BugCategoryDetailsLinePriority
Primitive value is boxed then unboxed to perform primitive coercion in org.deegree.tools.crs.georeferencing.application.listeners.FootprintMouseListener.mouseReleased(MouseEvent)PERFORMANCEBX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION113Medium

org.deegree.tools.crs.georeferencing.application.listeners.NavigationTreeSelectionListener

BugCategoryDetailsLinePriority
Possible null pointer dereference of panelType in org.deegree.tools.crs.georeferencing.application.listeners.NavigationTreeSelectionListener.valueChanged(TreeSelectionEvent)CORRECTNESSNP_NULL_ON_SOME_PATH88Medium

org.deegree.tools.crs.georeferencing.application.listeners.Scene2DMouseMotionListener

BugCategoryDetailsLinePriority
Primitive value is boxed then unboxed to perform primitive coercion in org.deegree.tools.crs.georeferencing.application.listeners.Scene2DMouseMotionListener.mouseDragged(MouseEvent)PERFORMANCEBX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION87Medium

org.deegree.tools.crs.georeferencing.application.transformation.AbstractTransformation

BugCategoryDetailsLinePriority
Unread public/protected field: org.deegree.tools.crs.georeferencing.application.transformation.AbstractTransformation.sceneValuesSTYLEURF_UNREAD_PUBLIC_OR_PROTECTED_FIELD81Medium

org.deegree.tools.crs.georeferencing.application.transformation.Polynomial

BugCategoryDetailsLinePriority
integral division result cast to double or float in org.deegree.tools.crs.georeferencing.application.transformation.Polynomial.computeRingList()STYLEICAST_IDIV_CAST_TO_DOUBLE135Medium
Unused field: org.deegree.tools.crs.georeferencing.application.transformation.Polynomial.xCPERFORMANCEUUF_UNUSED_FIELDMedium
Unused field: org.deegree.tools.crs.georeferencing.application.transformation.Polynomial.yCPERFORMANCEUUF_UNUSED_FIELDMedium

org.deegree.tools.crs.georeferencing.communication.PointTableFrame

BugCategoryDetailsLinePriority
org.deegree.tools.crs.georeferencing.communication.PointTableFrame.getColumnNames() may expose internal representation by returning PointTableFrame.columnNamesMALICIOUS_CODEEI_EXPOSE_REP235Medium

org.deegree.tools.crs.georeferencing.communication.dialog.AbstractGRDialog

BugCategoryDetailsLinePriority
Primitive value is boxed then unboxed to perform primitive coercion in new org.deegree.tools.crs.georeferencing.communication.dialog.AbstractGRDialog(Component, Dimension)PERFORMANCEBX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION85Medium
Primitive value is boxed then unboxed to perform primitive coercion in org.deegree.tools.crs.georeferencing.communication.dialog.AbstractGRDialog.setToCenter()PERFORMANCEBX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION120Medium

org.deegree.tools.crs.georeferencing.communication.dialog.coordinatejump.CoordinateJumperTextfieldDialog

BugCategoryDetailsLinePriority
Primitive value is boxed then unboxed to perform primitive coercion in new org.deegree.tools.crs.georeferencing.communication.dialog.coordinatejump.CoordinateJumperTextfieldDialog(Component)PERFORMANCEBX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION79Medium
org.deegree.tools.crs.georeferencing.communication.dialog.coordinatejump.CoordinateJumperTextfieldDialog.getCoords() may expose internal representation by returning CoordinateJumperTextfieldDialog.coordsMALICIOUS_CODEEI_EXPOSE_REP95Medium

org.deegree.tools.crs.georeferencing.communication.dialog.error.ErrorDialog

BugCategoryDetailsLinePriority
Switch statement found in new org.deegree.tools.crs.georeferencing.communication.dialog.error.ErrorDialog(Component, int, String) where default case is missingSTYLESF_SWITCH_NO_DEFAULT74Medium

org.deegree.tools.crs.georeferencing.communication.panel2D.AbstractPanel2D

BugCategoryDetailsLinePriority
org.deegree.tools.crs.georeferencing.communication.panel2D.AbstractPanel2D.selectedPointSize isn't final and can't be protected from malicious code MALICIOUS_CODEMS_CANNOT_BE_FINALMedium

org.deegree.tools.crs.georeferencing.communication.panel2D.BuildingFootprintPanel

BugCategoryDetailsLinePriority
Primitive value is boxed then unboxed to perform primitive coercion in org.deegree.tools.crs.georeferencing.communication.panel2D.BuildingFootprintPanel.paintComponent(Graphics)PERFORMANCEBX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION109Medium

org.deegree.tools.crs.georeferencing.model.buttons.ToggleButtonModel

BugCategoryDetailsLinePriority
new org.deegree.tools.crs.georeferencing.model.buttons.ToggleButtonModel(Pair[], ActionListener) may expose internal representation by storing an externally mutable object into ToggleButtonModel.abstractButtonsMALICIOUS_CODEEI_EXPOSE_REP266Medium

org.deegree.tools.i18n.Messages

BugCategoryDetailsLinePriority
org.deegree.tools.i18n.Messages.<static initializer>() may fail to clean up java.io.InputStreamEXPERIMENTALOBL_UNSATISFIED_OBLIGATION87Medium
org.deegree.tools.i18n.Messages.overrideMessages(String, Properties) may fail to clean up java.io.InputStream on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE116Medium
org.deegree.tools.i18n.Messages.<static initializer>() may fail to close streamBAD_PRACTICEOS_OPEN_STREAM87Medium
org.deegree.tools.i18n.Messages.overrideMessages(String, Properties) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR125Medium

org.deegree.tools.rendering.FlightControls

BugCategoryDetailsLinePriority
org.deegree.tools.rendering.FlightControls.keyPressed(KeyEvent) invokes System.exit(...), which shuts down the entire virtual machineBAD_PRACTICEDM_EXIT158Medium

org.deegree.tools.rendering.InteractiveWPVS

BugCategoryDetailsLinePriority
Redundant nullcheck of split, which is known to be non-null in org.deegree.tools.rendering.InteractiveWPVS.parseRequest(String)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE1243Medium
Switch statement found in org.deegree.tools.rendering.InteractiveWPVS.keyPressed(KeyEvent) where default case is missingSTYLESF_SWITCH_NO_DEFAULT657Medium

org.deegree.tools.rendering.dem.builder.DEMDatasetGenerator

BugCategoryDetailsLinePriority
Dead store to sT in org.deegree.tools.rendering.dem.builder.DEMDatasetGenerator.generateMacroTriangles(PatchManager, float, float, float, float)STYLEDLS_DEAD_LOCAL_STORE417Medium

org.deegree.tools.rendering.dem.builder.FileBlob

BugCategoryDetailsLinePriority
org.deegree.tools.rendering.dem.builder.FileBlob.getBytes(long, int) ignores result of java.io.RandomAccessFile.read(byte[])BAD_PRACTICERR_NOT_CHECKED83Medium

org.deegree.tools.rendering.dem.builder.MacroTriangle

BugCategoryDetailsLinePriority
org.deegree.tools.rendering.dem.builder.MacroTriangle.getBBox() may expose internal representation by returning MacroTriangle.bboxMALICIOUS_CODEEI_EXPOSE_REP261Medium

org.deegree.tools.rendering.dem.builder.dag.DAGBuilder

BugCategoryDetailsLinePriority
org.deegree.tools.rendering.dem.builder.dag.DAGBuilder.getArcs() may expose internal representation by returning DAGBuilder.arcsMALICIOUS_CODEEI_EXPOSE_REP161Medium
org.deegree.tools.rendering.dem.builder.dag.DAGBuilder.getNodes() may expose internal representation by returning DAGBuilder.nodesMALICIOUS_CODEEI_EXPOSE_REP165Medium
org.deegree.tools.rendering.dem.builder.dag.DAGBuilder.getPatchInfo() may expose internal representation by returning DAGBuilder.patchesMALICIOUS_CODEEI_EXPOSE_REP169Medium

org.deegree.tools.rendering.dem.builder.dag.DAGBuilder$DAGLevel

BugCategoryDetailsLinePriority
Should org.deegree.tools.rendering.dem.builder.dag.DAGBuilder$DAGLevel be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC555Medium
Unused field: org.deegree.tools.rendering.dem.builder.dag.DAGBuilder$DAGLevel.levelPERFORMANCEUUF_UNUSED_FIELDMedium

org.deegree.tools.rendering.dem.filtering.DEMRasterFilterer

BugCategoryDetailsLinePriority
Synchronization on interned String in org.deegree.tools.rendering.dem.filtering.DEMRasterFilterer.applyFilter()MT_CORRECTNESSDL_SYNCHRONIZATION_ON_SHARED_CONSTANT204Medium

org.deegree.tools.rendering.dem.filtering.DEMRasterFilterer$FilteredResultWiter

BugCategoryDetailsLinePriority
Should org.deegree.tools.rendering.dem.filtering.DEMRasterFilterer$FilteredResultWiter be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC576Medium

org.deegree.tools.rendering.dem.filtering.DEMRasterFilterer$RasterComparator

BugCategoryDetailsLinePriority
Should org.deegree.tools.rendering.dem.filtering.DEMRasterFilterer$RasterComparator be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC527Medium

org.deegree.tools.rendering.dem.filtering.DEMRasterFilterer$RasterFilterer

BugCategoryDetailsLinePriority
Should org.deegree.tools.rendering.dem.filtering.DEMRasterFilterer$RasterFilterer be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC482Medium

org.deegree.tools.rendering.dem.filtering.filters.SmoothingFilter

BugCategoryDetailsLinePriority
Dead store to mean in org.deegree.tools.rendering.dem.filtering.filters.SmoothingFilter.calcKernelStdev(RasterData)STYLEDLS_DEAD_LOCAL_STORE251Medium

org.deegree.tools.rendering.manager.DataManager

BugCategoryDetailsLinePriority
Dead store to hostURL in org.deegree.tools.rendering.manager.DataManager.getModelBackend(CommandLine)STYLEDLS_DEAD_LOCAL_STORE314Medium
Dead store to textureDir in org.deegree.tools.rendering.manager.DataManager.startManager(CommandLine)STYLEDLS_DEAD_LOCAL_STORE279Medium

org.deegree.tools.rendering.manager.buildings.generalisation.WorldObjectSimplifier$RegressionForm

BugCategoryDetailsLinePriority
Should org.deegree.tools.rendering.manager.buildings.generalisation.WorldObjectSimplifier$RegressionForm be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC321Medium

org.deegree.tools.rendering.manager.buildings.importers.VRMLImporter

BugCategoryDetailsLinePriority
Redundant nullcheck of normals, which is known to be non-null in org.deegree.tools.rendering.manager.buildings.importers.VRMLImporter.importShape3D(RenderableQualityModel, Shape3D, Transform3D, double[], double[])STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE536Medium
exceptional return value of java.io.File.mkdir() ignored in new org.deegree.tools.rendering.manager.buildings.importers.VRMLImporter(Map)BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE186Medium

org.deegree.tools.rendering.manager.stage.StageManager

BugCategoryDetailsLinePriority
Found reliance on default encoding in org.deegree.tools.rendering.manager.stage.StageManager.importFromFile(File, CommandLine): new java.io.FileReader(File)I18NDM_DEFAULT_ENCODING183High
Found reliance on default encoding in org.deegree.tools.rendering.manager.stage.StageManager.importFromFile(File, CommandLine): new java.io.FileWriter(File)I18NDM_DEFAULT_ENCODING200High
Found reliance on default encoding in org.deegree.tools.rendering.manager.stage.StageManager.readAndImportStages(CSVReader, Map, int): new java.io.FileWriter(File)I18NDM_DEFAULT_ENCODING222High
org.deegree.tools.rendering.manager.stage.StageManager.importFromFile(File, CommandLine) may fail to clean up java.io.Writer on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE200Medium
org.deegree.tools.rendering.manager.stage.StageManager.readAndImportStages(CSVReader, Map, int) may fail to clean up java.io.Writer on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE222Medium

org.deegree.tools.rendering.manager.trees.TreeManager

BugCategoryDetailsLinePriority
Found reliance on default encoding in org.deegree.tools.rendering.manager.trees.TreeManager.importFromFile(File, CommandLine): new java.io.FileReader(File)I18NDM_DEFAULT_ENCODING164High

org.deegree.tools.rendering.viewer.Export3DFile

BugCategoryDetailsLinePriority
Dead store to tmpExporter in org.deegree.tools.rendering.viewer.Export3DFile.exportBranchgroup(MemoryAware)STYLEDLS_DEAD_LOCAL_STORE229Medium
Redundant nullcheck of org.deegree.tools.rendering.viewer.Export3DFile.selectedExporter which is known to be null in org.deegree.tools.rendering.viewer.Export3DFile.exportBranchgroup(MemoryAware)STYLERCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE210Medium
org.deegree.tools.rendering.viewer.Export3DFile.createParameterDialog(J3DExporter) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR293Medium

org.deegree.tools.rendering.viewer.File3dExporter

BugCategoryDetailsLinePriority
Found reliance on default encoding in org.deegree.tools.rendering.viewer.File3dExporter.save(GLViewer, WorldRenderableObject): new java.io.FileWriter(File)I18NDM_DEFAULT_ENCODING93High

org.deegree.tools.rendering.viewer.File3dImporter

BugCategoryDetailsLinePriority
org.deegree.tools.rendering.viewer.File3dImporter.gm isn't final and can't be protected from malicious code MALICIOUS_CODEMS_CANNOT_BE_FINALMedium