FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 2.0.1

Threshold is medium

Effort is min

Summary

ClassesBugsErrorsMissing Classes
892100

org.deegree.services.authentication.HttpBasicAuthentication

BugCategoryDetailsLinePriority
Found reliance on default encoding in org.deegree.services.authentication.HttpBasicAuthentication.doBasicAuthentication(HttpServletRequest, HttpServletResponse): new String(byte[])I18NDM_DEFAULT_ENCODING135High

org.deegree.services.controller.AbstractOWS

BugCategoryDetailsLinePriority
org.deegree.services.controller.AbstractOWS.sendException(Map, ExceptionSerializer, OWSException, HttpResponseBuffer) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR540Medium

org.deegree.services.controller.ImplementationMetadata

BugCategoryDetailsLinePriority
org.deegree.services.controller.ImplementationMetadata.getImplementedServiceName() may expose internal representation by returning ImplementationMetadata.serviceNameMALICIOUS_CODEEI_EXPOSE_REP197Medium

org.deegree.services.controller.OGCFrontController

BugCategoryDetailsLinePriority
Found reliance on default encoding in org.deegree.services.controller.OGCFrontController.getActiveWorkspaceName(): new java.io.FileReader(File)I18NDM_DEFAULT_ENCODING1265High
Found reliance on default encoding in org.deegree.services.controller.OGCFrontController.readPostBodyAsString(InputStream): java.io.ByteArrayOutputStream.toString()I18NDM_DEFAULT_ENCODING635High
exceptional return value of java.io.File.mkdirs() ignored in org.deegree.services.controller.OGCFrontController.createLoggingResponseWrapper(HttpServletRequest, HttpServletResponse)BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE549Medium
The field org.deegree.services.controller.OGCFrontController.hardcodedResourcesUrl is transient but isn't set by deserializationBAD_PRACTICESE_TRANSIENT_FIELD_NOT_RESTOREDMedium
The field org.deegree.services.controller.OGCFrontController.hardcodedServicesUrl is transient but isn't set by deserializationBAD_PRACTICESE_TRANSIENT_FIELD_NOT_RESTOREDMedium
Write to static field org.deegree.services.controller.OGCFrontController.instance from instance method org.deegree.services.controller.OGCFrontController.init(ServletConfig)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD1034High

org.deegree.services.controller.security.SecureProxy

BugCategoryDetailsLinePriority
exceptional return value of java.io.File.mkdirs() ignored in org.deegree.services.controller.security.SecureProxy.doPost(HttpServletRequest, HttpServletResponse)BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE196Medium

org.deegree.services.controller.utils.OSAASRequestLogger

BugCategoryDetailsLinePriority
Found reliance on default encoding in org.deegree.services.controller.utils.OSAASRequestLogger.logKVP(String, String, long, long, Credentials): String.getBytes()I18NDM_DEFAULT_ENCODING105High
org.deegree.services.controller.utils.OSAASRequestLogger.logXML(String, File, long, long, Credentials) may fail to clean up java.io.InputStreamEXPERIMENTALOBL_UNSATISFIED_OBLIGATION146Medium
A prepared statement is generated from a nonconstant String in org.deegree.services.controller.utils.OSAASRequestLogger.logKVP(String, String, long, long, Credentials) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING96Medium
A prepared statement is generated from a nonconstant String in org.deegree.services.controller.utils.OSAASRequestLogger.logXML(String, File, long, long, Credentials) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING137Medium

org.deegree.services.i18n.Messages

BugCategoryDetailsLinePriority
org.deegree.services.i18n.Messages.<static initializer>() may fail to clean up java.io.InputStream on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE90Medium
org.deegree.services.i18n.Messages.<static initializer>() may fail to close streamBAD_PRACTICEOS_OPEN_STREAM90Medium
org.deegree.services.i18n.Messages.overrideMessages(String, Properties) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR132Medium

org.deegree.services.metadata.OWSMetadataProviderManager

BugCategoryDetailsLinePriority
Load of known null value in org.deegree.services.metadata.OWSMetadataProviderManager.processResourceConfig(File)STYLENP_LOAD_OF_KNOWN_NULL_VALUE150Medium

org.deegree.services.ows.capabilities.OWSCapabilitiesXMLAdapter

BugCategoryDetailsLinePriority
Redundant nullcheck of org.deegree.services.jaxb.metadata.ServiceContactType.getElectronicMailAddress(), which is known to be non-null in org.deegree.services.ows.capabilities.OWSCapabilitiesXMLAdapter.exportServiceProvider100Old(XMLStreamWriter, ServiceProviderType)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE351Medium
Redundant nullcheck of org.deegree.services.jaxb.metadata.ServiceContactType.getElectronicMailAddress(), which is known to be non-null in org.deegree.services.ows.capabilities.OWSCapabilitiesXMLAdapter.exportServiceProvider110(XMLStreamWriter, ServiceProviderType)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE445Medium

org.deegree.services.resources.ResourcesServlet

BugCategoryDetailsLinePriority
org.deegree.services.resources.ResourcesServlet.sendResource(File, HttpServletResponse) may fail to clean up java.io.InputStream on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE118Medium