FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 2.0.1

Threshold is medium

Effort is min

Summary

ClassesBugsErrorsMissing Classes
2716500

Files

ClassBugs
org.deegree.commons.config.AbstractResourceManager1
org.deegree.commons.config.DeegreeWorkspace2
org.deegree.commons.dataaccess.CSVReader1
org.deegree.commons.index.QTree2
org.deegree.commons.index.QTree$Entry1
org.deegree.commons.jdbc.UpdateRow1
org.deegree.commons.mail.MailHelper2
org.deegree.commons.modules.ModuleInfo3
org.deegree.commons.ows.metadata.Description1
org.deegree.commons.struct.Tree1
org.deegree.commons.tom.Object1
org.deegree.commons.tom.Reference1
org.deegree.commons.tom.array.TypedObjectNodeArray2
org.deegree.commons.tom.datetime.Date1
org.deegree.commons.tom.datetime.DateTime1
org.deegree.commons.tom.datetime.Time1
org.deegree.commons.tom.datetime.TimeInstant1
org.deegree.commons.tom.gml.GenericGMLObjectType1
org.deegree.commons.tom.ows.StringOrRef1
org.deegree.commons.tom.primitive.PrimitiveValue3
org.deegree.commons.tools.CommandUtils1
org.deegree.commons.tools.ToolBox$ToolInfo2
org.deegree.commons.utils.ConfigManager1
org.deegree.commons.utils.DeegreeAALogoUtils3
org.deegree.commons.utils.EncodingGuesser1
org.deegree.commons.utils.FileUtils1
org.deegree.commons.utils.JDBCUtils2
org.deegree.commons.utils.ProxyUtils3
org.deegree.commons.utils.RequestUtils1
org.deegree.commons.utils.TempFileManager1
org.deegree.commons.utils.io.StreamBufferStore1
org.deegree.commons.utils.io.Zip3
org.deegree.commons.utils.jaxb.CreateExternalBindings1
org.deegree.commons.utils.kvp.KVPUtils3
org.deegree.commons.utils.net.HttpUtils7
org.deegree.commons.utils.test.TestProperties3
org.deegree.commons.xml.schema.ErrorHandler1
org.deegree.commons.xml.schema.GrammarPoolManager1
org.deegree.commons.xml.stax.StAXExportingHelper1

org.deegree.commons.config.AbstractResourceManager

BugCategoryDetailsLinePriority
Load of known null value in org.deegree.commons.config.AbstractResourceManager.processResourceConfig(File)STYLENP_LOAD_OF_KNOWN_NULL_VALUE286Medium

org.deegree.commons.config.DeegreeWorkspace

BugCategoryDetailsLinePriority
org.deegree.commons.config.DeegreeWorkspace.getModulesInfo() is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS131High
org.deegree.commons.config.DeegreeWorkspace.initManagers() makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR218Medium

org.deegree.commons.dataaccess.CSVReader

BugCategoryDetailsLinePriority
org.deegree.commons.dataaccess.CSVReader.parseLine() may expose internal representation by returning CSVReader.columnNamesMALICIOUS_CODEEI_EXPOSE_REP164Medium

org.deegree.commons.index.QTree

BugCategoryDetailsLinePriority
Switch statement found in org.deegree.commons.index.QTree.bboxForSon(int) where default case is missingSTYLESF_SWITCH_NO_DEFAULT587Medium
Switch statement found in org.deegree.commons.index.QTree.getDotVertex(int, int, boolean) where default case is missingSTYLESF_SWITCH_NO_DEFAULT870Medium

org.deegree.commons.index.QTree$Entry

BugCategoryDetailsLinePriority
org.deegree.commons.index.QTree$Entry is serializable and an inner classBAD_PRACTICESE_INNER_CLASS762Medium

org.deegree.commons.jdbc.UpdateRow

BugCategoryDetailsLinePriority
org.deegree.commons.jdbc.UpdateRow.performUpdate(Connection) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE112Medium

org.deegree.commons.mail.MailHelper

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.deegree.commons.mail.MailHelper.createAndSendMail(MailMessage, Session, File[], String[])STYLEREC_CATCH_EXCEPTION276Medium
Exception is caught when Exception is not thrown in org.deegree.commons.mail.MailHelper.createAndSendMail(MailMessage, Session, Object[], String[])STYLEREC_CATCH_EXCEPTION214Medium

org.deegree.commons.modules.ModuleInfo

BugCategoryDetailsLinePriority
org.deegree.commons.modules.ModuleInfo.extractModulesInfo(Set) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS121High
org.deegree.commons.modules.ModuleInfo.extractModuleInfo(URL) creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged blockMALICIOUS_CODEDP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED160Medium
org.deegree.commons.modules.ModuleInfo defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE206High

org.deegree.commons.ows.metadata.Description

BugCategoryDetailsLinePriority
Unused field: org.deegree.commons.ows.metadata.Description.langToKeywordsPERFORMANCEUUF_UNUSED_FIELDMedium

org.deegree.commons.struct.Tree

BugCategoryDetailsLinePriority
Unwritten public or protected field: org.deegree.commons.struct.Tree.valueSTYLEUWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD57Medium

org.deegree.commons.tom.Object

BugCategoryDetailsLinePriority
The class name org.deegree.commons.tom.Object shadows the simple name of the superclass java.lang.ObjectBAD_PRACTICENM_SAME_SIMPLE_NAME_AS_SUPERCLASSHigh

org.deegree.commons.tom.Reference

BugCategoryDetailsLinePriority
Inconsistent synchronization of org.deegree.commons.tom.Reference.object; locked 40% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC121Medium

org.deegree.commons.tom.array.TypedObjectNodeArray

BugCategoryDetailsLinePriority
org.deegree.commons.tom.array.TypedObjectNodeArray.getElements() may expose internal representation by returning TypedObjectNodeArray.elementsMALICIOUS_CODEEI_EXPOSE_REP68Medium
new org.deegree.commons.tom.array.TypedObjectNodeArray(TypedObjectNode[]) may expose internal representation by storing an externally mutable object into TypedObjectNodeArray.elementsMALICIOUS_CODEEI_EXPOSE_REP261Medium

org.deegree.commons.tom.datetime.Date

BugCategoryDetailsLinePriority
org.deegree.commons.tom.datetime.Date inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE52Medium

org.deegree.commons.tom.datetime.DateTime

BugCategoryDetailsLinePriority
org.deegree.commons.tom.datetime.DateTime inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE52Medium

org.deegree.commons.tom.datetime.Time

BugCategoryDetailsLinePriority
org.deegree.commons.tom.datetime.Time inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE51Medium

org.deegree.commons.tom.datetime.TimeInstant

BugCategoryDetailsLinePriority
org.deegree.commons.tom.datetime.TimeInstant defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE167Medium

org.deegree.commons.tom.gml.GenericGMLObjectType

BugCategoryDetailsLinePriority
org.deegree.commons.tom.gml.GenericGMLObjectType.toString() concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION87Medium

org.deegree.commons.tom.ows.StringOrRef

BugCategoryDetailsLinePriority
org.deegree.commons.tom.ows.StringOrRef.equals(Object) checks for operand being a String BAD_PRACTICEEQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS95High

org.deegree.commons.tom.primitive.PrimitiveValue

BugCategoryDetailsLinePriority
instanceof will always return false in org.deegree.commons.tom.primitive.PrimitiveValue.makeComparable(Object, Object), since a String can't be a BooleanCORRECTNESSBC_IMPOSSIBLE_INSTANCEOF250Medium
instanceof will always return false in org.deegree.commons.tom.primitive.PrimitiveValue.makeComparable(Object, Object), since a String can't be a org.deegree.commons.tom.ows.CodeTypeCORRECTNESSBC_IMPOSSIBLE_INSTANCEOF258Medium
instanceof will always return false in org.deegree.commons.tom.primitive.PrimitiveValue.makeComparable(Object, Object), since a String can't be a org.deegree.commons.uom.MeasureCORRECTNESSBC_IMPOSSIBLE_INSTANCEOF261Medium

org.deegree.commons.tools.CommandUtils

BugCategoryDetailsLinePriority
org.deegree.commons.tools.CommandUtils.HELP_TEXT_WIDTH isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL59High

org.deegree.commons.tools.ToolBox$ToolInfo

BugCategoryDetailsLinePriority
org.deegree.commons.tools.ToolBox$ToolInfo.toString() may return nullBAD_PRACTICENP_TOSTRING_COULD_RETURN_NULL435Medium
Should org.deegree.commons.tools.ToolBox$ToolInfo be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC380Medium

org.deegree.commons.utils.ConfigManager

BugCategoryDetailsLinePriority
exceptional return value of java.io.File.mkdirs() ignored in org.deegree.commons.utils.ConfigManager.<static initializer>()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE64Medium

org.deegree.commons.utils.DeegreeAALogoUtils

BugCategoryDetailsLinePriority
Found reliance on default encoding in org.deegree.commons.utils.DeegreeAALogoUtils.print(OutputStream): String.getBytes()I18NDM_DEFAULT_ENCODING117High
org.deegree.commons.utils.DeegreeAALogoUtils.<static initializer>() may fail to close streamBAD_PRACTICEOS_OPEN_STREAM69Medium
Exception is caught when Exception is not thrown in org.deegree.commons.utils.DeegreeAALogoUtils.<static initializer>()STYLEREC_CATCH_EXCEPTION74Medium

org.deegree.commons.utils.EncodingGuesser

BugCategoryDetailsLinePriority
org.deegree.commons.utils.EncodingGuesser.guess(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR146Medium

org.deegree.commons.utils.FileUtils

BugCategoryDetailsLinePriority
Found reliance on default encoding in org.deegree.commons.utils.FileUtils.writeFile(File, String): new java.io.FileWriter(File)I18NDM_DEFAULT_ENCODING178High

org.deegree.commons.utils.JDBCUtils

BugCategoryDetailsLinePriority
org.deegree.commons.utils.JDBCUtils.determinePostGISVersion(Connection, Logger) may fail to clean up java.sql.ResultSetEXPERIMENTALOBL_UNSATISFIED_OBLIGATION166Medium
org.deegree.commons.utils.JDBCUtils.determinePostGISVersion(Connection, Logger) may fail to clean up java.sql.StatementEXPERIMENTALOBL_UNSATISFIED_OBLIGATION165Medium

org.deegree.commons.utils.ProxyUtils

BugCategoryDetailsLinePriority
Found reliance on default encoding in org.deegree.commons.utils.ProxyUtils.openURLConnection(URL, String, String): String.getBytes()I18NDM_DEFAULT_ENCODING338High
Found reliance on default encoding in org.deegree.commons.utils.ProxyUtils.openURLConnection(URL, String, String, String, String): String.getBytes()I18NDM_DEFAULT_ENCODING310High
Found reliance on default encoding in org.deegree.commons.utils.ProxyUtils.openURLConnection(URL, String, String, String, String): String.getBytes()I18NDM_DEFAULT_ENCODING315High

org.deegree.commons.utils.RequestUtils

BugCategoryDetailsLinePriority
org.deegree.commons.utils.RequestUtils.replaceParameters(Map, Map, Map, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR78Medium

org.deegree.commons.utils.TempFileManager

BugCategoryDetailsLinePriority
exceptional return value of java.io.File.mkdir() ignored in org.deegree.commons.utils.TempFileManager.init(String)BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE86Medium

org.deegree.commons.utils.io.StreamBufferStore

BugCategoryDetailsLinePriority
exceptional return value of java.io.File.delete() ignored in org.deegree.commons.utils.io.StreamBufferStore.reset()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE209Medium

org.deegree.commons.utils.io.Zip

BugCategoryDetailsLinePriority
org.deegree.commons.utils.io.Zip.unzip(InputStream, File, boolean) may fail to clean up java.io.OutputStream on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE101Medium
exceptional return value of java.io.File.mkdir() ignored in org.deegree.commons.utils.io.Zip.unzip(InputStream, File, boolean)BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE72Medium
exceptional return value of java.io.File.mkdirs() ignored in org.deegree.commons.utils.io.Zip.unzip(InputStream, File, boolean)BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE100Medium

org.deegree.commons.utils.jaxb.CreateExternalBindings

BugCategoryDetailsLinePriority
Found reliance on default encoding in org.deegree.commons.utils.jaxb.CreateExternalBindings.matchSCDType(String, String): new java.io.FileReader(String)I18NDM_DEFAULT_ENCODING232High

org.deegree.commons.utils.kvp.KVPUtils

BugCategoryDetailsLinePriority
Found reliance on default encoding in org.deegree.commons.utils.kvp.KVPUtils.readFileIntoMap(URL): new java.io.InputStreamReader(InputStream)I18NDM_DEFAULT_ENCODING353High
org.deegree.commons.utils.kvp.KVPUtils.readFileIntoMap(URL) may fail to close streamBAD_PRACTICEOS_OPEN_STREAM353Medium
org.deegree.commons.utils.kvp.KVPUtils.getNormalizedKVPMap(String, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR422Medium

org.deegree.commons.utils.net.HttpUtils

BugCategoryDetailsLinePriority
org.deegree.commons.utils.net.HttpUtils.get(HttpUtils$Worker, String, Map, String, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR472Medium
org.deegree.commons.utils.net.HttpUtils.getFullResponse(HttpUtils$Worker, String, Map, String, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR508Medium
org.deegree.commons.utils.net.HttpUtils.getFullResponse(HttpUtils$Worker, String, Map, String, String, int) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR592Medium
org.deegree.commons.utils.net.HttpUtils.post(HttpUtils$Worker, String, File, Map, String, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR419Medium
org.deegree.commons.utils.net.HttpUtils.post(HttpUtils$Worker, String, InputStream, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR287Medium
org.deegree.commons.utils.net.HttpUtils.post(HttpUtils$Worker, String, Map, Map, int) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR328Medium
org.deegree.commons.utils.net.HttpUtils.postFullResponse(HttpUtils$Worker, String, Map, Map, int) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR371Medium

org.deegree.commons.utils.test.TestProperties

BugCategoryDetailsLinePriority
Found reliance on default encoding in org.deegree.commons.utils.test.TestProperties.<static initializer>(): new java.io.FileReader(File)I18NDM_DEFAULT_ENCODING67High
org.deegree.commons.utils.test.TestProperties.<static initializer>() may fail to clean up java.io.ReaderEXPERIMENTALOBL_UNSATISFIED_OBLIGATION67Medium
org.deegree.commons.utils.test.TestProperties.<static initializer>() may fail to close streamBAD_PRACTICEOS_OPEN_STREAM67Medium

org.deegree.commons.xml.schema.ErrorHandler

BugCategoryDetailsLinePriority
Switch statement found in org.deegree.commons.xml.schema.ErrorHandler.handleError(DOMError) where default case is missingSTYLESF_SWITCH_NO_DEFAULT580Medium

org.deegree.commons.xml.schema.GrammarPoolManager

BugCategoryDetailsLinePriority
org.deegree.commons.xml.schema.GrammarPoolManager.createGrammarPool(String[]) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION130Medium

org.deegree.commons.xml.stax.StAXExportingHelper

BugCategoryDetailsLinePriority
Switch statement found in org.deegree.commons.xml.stax.StAXExportingHelper.writeStartElement(XMLStreamWriter, QName) where default case is missingSTYLESF_SWITCH_NO_DEFAULT86Medium