FindBugs Bug Detector Report
The following document contains the results of FindBugs Report
FindBugs Version is 2.0.1
Threshold is medium
Effort is min
Summary
| Classes | Bugs | Errors | Missing Classes |
|---|
| 89 | 21 | 0 | 0 |
org.deegree.services.authentication.HttpBasicAuthentication
| Bug | Category | Details | Line | Priority |
|---|
| Found reliance on default encoding in org.deegree.services.authentication.HttpBasicAuthentication.doBasicAuthentication(HttpServletRequest, HttpServletResponse): new String(byte[]) | I18N | DM_DEFAULT_ENCODING | 135 | High |
org.deegree.services.controller.AbstractOWS
| Bug | Category | Details | Line | Priority |
|---|
| org.deegree.services.controller.AbstractOWS.sendException(Map, ExceptionSerializer, OWSException, HttpResponseBuffer) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 540 | Medium |
org.deegree.services.controller.ImplementationMetadata
| Bug | Category | Details | Line | Priority |
|---|
| org.deegree.services.controller.ImplementationMetadata.getImplementedServiceName() may expose internal representation by returning ImplementationMetadata.serviceName | MALICIOUS_CODE | EI_EXPOSE_REP | 197 | Medium |
org.deegree.services.controller.OGCFrontController
| Bug | Category | Details | Line | Priority |
|---|
| Found reliance on default encoding in org.deegree.services.controller.OGCFrontController.getActiveWorkspaceName(): new java.io.FileReader(File) | I18N | DM_DEFAULT_ENCODING | 1265 | High |
| Found reliance on default encoding in org.deegree.services.controller.OGCFrontController.readPostBodyAsString(InputStream): java.io.ByteArrayOutputStream.toString() | I18N | DM_DEFAULT_ENCODING | 635 | High |
| exceptional return value of java.io.File.mkdirs() ignored in org.deegree.services.controller.OGCFrontController.createLoggingResponseWrapper(HttpServletRequest, HttpServletResponse) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 549 | Medium |
| The field org.deegree.services.controller.OGCFrontController.hardcodedResourcesUrl is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | | Medium |
| The field org.deegree.services.controller.OGCFrontController.hardcodedServicesUrl is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | | Medium |
| Write to static field org.deegree.services.controller.OGCFrontController.instance from instance method org.deegree.services.controller.OGCFrontController.init(ServletConfig) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 1034 | High |
org.deegree.services.controller.security.SecureProxy
| Bug | Category | Details | Line | Priority |
|---|
| exceptional return value of java.io.File.mkdirs() ignored in org.deegree.services.controller.security.SecureProxy.doPost(HttpServletRequest, HttpServletResponse) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 196 | Medium |
org.deegree.services.controller.utils.OSAASRequestLogger
| Bug | Category | Details | Line | Priority |
|---|
| Found reliance on default encoding in org.deegree.services.controller.utils.OSAASRequestLogger.logKVP(String, String, long, long, Credentials): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 105 | High |
| org.deegree.services.controller.utils.OSAASRequestLogger.logXML(String, File, long, long, Credentials) may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 146 | Medium |
| A prepared statement is generated from a nonconstant String in org.deegree.services.controller.utils.OSAASRequestLogger.logKVP(String, String, long, long, Credentials) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 96 | Medium |
| A prepared statement is generated from a nonconstant String in org.deegree.services.controller.utils.OSAASRequestLogger.logXML(String, File, long, long, Credentials) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 137 | Medium |
org.deegree.services.i18n.Messages
| Bug | Category | Details | Line | Priority |
|---|
| org.deegree.services.i18n.Messages.<static initializer>() may fail to clean up java.io.InputStream on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 90 | Medium |
| org.deegree.services.i18n.Messages.<static initializer>() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 90 | Medium |
| org.deegree.services.i18n.Messages.overrideMessages(String, Properties) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 132 | Medium |
org.deegree.services.metadata.OWSMetadataProviderManager
| Bug | Category | Details | Line | Priority |
|---|
| Load of known null value in org.deegree.services.metadata.OWSMetadataProviderManager.processResourceConfig(File) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 150 | Medium |
org.deegree.services.ows.capabilities.OWSCapabilitiesXMLAdapter
| Bug | Category | Details | Line | Priority |
|---|
| Redundant nullcheck of org.deegree.services.jaxb.metadata.ServiceContactType.getElectronicMailAddress(), which is known to be non-null in org.deegree.services.ows.capabilities.OWSCapabilitiesXMLAdapter.exportServiceProvider100Old(XMLStreamWriter, ServiceProviderType) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 351 | Medium |
| Redundant nullcheck of org.deegree.services.jaxb.metadata.ServiceContactType.getElectronicMailAddress(), which is known to be non-null in org.deegree.services.ows.capabilities.OWSCapabilitiesXMLAdapter.exportServiceProvider110(XMLStreamWriter, ServiceProviderType) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 445 | Medium |
org.deegree.services.resources.ResourcesServlet
| Bug | Category | Details | Line | Priority |
|---|
| org.deegree.services.resources.ResourcesServlet.sendResource(File, HttpServletResponse) may fail to clean up java.io.InputStream on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 118 | Medium |
