The following document contains the results of FindBugs Report
FindBugs Version is 2.0.1
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.deegree.tools.binding.CityGMLImporterGenerator.writeNewFile(File, ModelClass, HashMap): new java.io.FileWriter(File) | I18N | DM_DEFAULT_ENCODING | 205 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.deegree.tools.crs.georeferencing.communication.panel2D.AbstractPanel2D.selectedPointSize from instance method new org.deegree.tools.crs.georeferencing.application.Controller(GRViewerGUI, ApplicationState) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 99 | High |
| Write to static field org.deegree.tools.crs.georeferencing.communication.panel2D.AbstractPanel2D.zoomValue from instance method new org.deegree.tools.crs.georeferencing.application.Controller(GRViewerGUI, ApplicationState) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 100 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive value is boxed then unboxed to perform primitive coercion in org.deegree.tools.crs.georeferencing.application.Scene2DValues.getPixelCoord(AbstractGRPoint) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 210 | Medium |
| Unwritten field: org.deegree.tools.crs.georeferencing.application.Scene2DValues.selectedLayers | CORRECTNESS | UWF_UNWRITTEN_FIELD | 634 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in new org.deegree.tools.crs.georeferencing.application.handler.FileInputHandler(PointTableFrame): new java.io.FileReader(String) | I18N | DM_DEFAULT_ENCODING | 79 | High |
| Null passed for nonnull parameter of new java.io.BufferedReader(Reader) in new org.deegree.tools.crs.georeferencing.application.handler.FileInputHandler(PointTableFrame) | CORRECTNESS | NP_NULL_PARAM_DEREF | 84 | Medium |
| new org.deegree.tools.crs.georeferencing.application.handler.FileInputHandler(PointTableFrame) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 84 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in new org.deegree.tools.crs.georeferencing.application.handler.FileOutputHandler(PointTableFrame): new java.io.FileWriter(String) | I18N | DM_DEFAULT_ENCODING | 77 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.tools.crs.georeferencing.application.listeners.ButtonListener.actionPerformed(ActionEvent) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 291 | Medium |
| Write to static field org.deegree.tools.crs.georeferencing.communication.panel2D.AbstractPanel2D.selectedPointSize from instance method org.deegree.tools.crs.georeferencing.application.listeners.ButtonListener.actionPerformed(ActionEvent) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 157 | High |
| Write to static field org.deegree.tools.crs.georeferencing.application.listeners.ButtonListener.colorIndex from instance method org.deegree.tools.crs.georeferencing.application.listeners.ButtonListener.actionPerformed(ActionEvent) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 395 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive value is boxed then unboxed to perform primitive coercion in org.deegree.tools.crs.georeferencing.application.listeners.FootprintMouseListener.mouseReleased(MouseEvent) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 113 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of panelType in org.deegree.tools.crs.georeferencing.application.listeners.NavigationTreeSelectionListener.valueChanged(TreeSelectionEvent) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 88 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive value is boxed then unboxed to perform primitive coercion in org.deegree.tools.crs.georeferencing.application.listeners.Scene2DMouseMotionListener.mouseDragged(MouseEvent) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 87 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread public/protected field: org.deegree.tools.crs.georeferencing.application.transformation.AbstractTransformation.sceneValues | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 81 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| integral division result cast to double or float in org.deegree.tools.crs.georeferencing.application.transformation.Polynomial.computeRingList() | STYLE | ICAST_IDIV_CAST_TO_DOUBLE | 135 | Medium |
| Unused field: org.deegree.tools.crs.georeferencing.application.transformation.Polynomial.xC | PERFORMANCE | UUF_UNUSED_FIELD | Medium | |
| Unused field: org.deegree.tools.crs.georeferencing.application.transformation.Polynomial.yC | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.tools.crs.georeferencing.communication.PointTableFrame.getColumnNames() may expose internal representation by returning PointTableFrame.columnNames | MALICIOUS_CODE | EI_EXPOSE_REP | 235 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive value is boxed then unboxed to perform primitive coercion in new org.deegree.tools.crs.georeferencing.communication.dialog.AbstractGRDialog(Component, Dimension) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 85 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in org.deegree.tools.crs.georeferencing.communication.dialog.AbstractGRDialog.setToCenter() | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 120 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive value is boxed then unboxed to perform primitive coercion in new org.deegree.tools.crs.georeferencing.communication.dialog.coordinatejump.CoordinateJumperTextfieldDialog(Component) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 79 | Medium |
| org.deegree.tools.crs.georeferencing.communication.dialog.coordinatejump.CoordinateJumperTextfieldDialog.getCoords() may expose internal representation by returning CoordinateJumperTextfieldDialog.coords | MALICIOUS_CODE | EI_EXPOSE_REP | 95 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Switch statement found in new org.deegree.tools.crs.georeferencing.communication.dialog.error.ErrorDialog(Component, int, String) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 74 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.tools.crs.georeferencing.communication.panel2D.AbstractPanel2D.selectedPointSize isn't final and can't be protected from malicious code | MALICIOUS_CODE | MS_CANNOT_BE_FINAL | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive value is boxed then unboxed to perform primitive coercion in org.deegree.tools.crs.georeferencing.communication.panel2D.BuildingFootprintPanel.paintComponent(Graphics) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 109 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.deegree.tools.crs.georeferencing.model.buttons.ToggleButtonModel(Pair[], ActionListener) may expose internal representation by storing an externally mutable object into ToggleButtonModel.abstractButtons | MALICIOUS_CODE | EI_EXPOSE_REP2 | 66 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.tools.i18n.Messages.<static initializer>() may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 87 | Medium |
| org.deegree.tools.i18n.Messages.overrideMessages(String, Properties) may fail to clean up java.io.InputStream on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 116 | Medium |
| org.deegree.tools.i18n.Messages.<static initializer>() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 87 | Medium |
| org.deegree.tools.i18n.Messages.overrideMessages(String, Properties) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 125 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.tools.rendering.FlightControls.keyPressed(KeyEvent) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 158 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of split, which is known to be non-null in org.deegree.tools.rendering.InteractiveWPVS.parseRequest(String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 1239 | Medium |
| Switch statement found in org.deegree.tools.rendering.InteractiveWPVS.keyPressed(KeyEvent) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 655 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to sT in org.deegree.tools.rendering.dem.builder.DEMDatasetGenerator.generateMacroTriangles(PatchManager, float, float, float, float) | STYLE | DLS_DEAD_LOCAL_STORE | 417 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.tools.rendering.dem.builder.FileBlob.getBytes(long, int) ignores result of java.io.RandomAccessFile.read(byte[]) | BAD_PRACTICE | RR_NOT_CHECKED | 83 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.tools.rendering.dem.builder.MacroTriangle.getBBox() may expose internal representation by returning MacroTriangle.bbox | MALICIOUS_CODE | EI_EXPOSE_REP | 261 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.tools.rendering.dem.builder.dag.DAGBuilder.getArcs() may expose internal representation by returning DAGBuilder.arcs | MALICIOUS_CODE | EI_EXPOSE_REP | 161 | Medium |
| org.deegree.tools.rendering.dem.builder.dag.DAGBuilder.getNodes() may expose internal representation by returning DAGBuilder.nodes | MALICIOUS_CODE | EI_EXPOSE_REP | 165 | Medium |
| org.deegree.tools.rendering.dem.builder.dag.DAGBuilder.getPatchInfo() may expose internal representation by returning DAGBuilder.patches | MALICIOUS_CODE | EI_EXPOSE_REP | 169 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.deegree.tools.rendering.dem.builder.dag.DAGBuilder$DAGLevel be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 555 | Medium |
| Unused field: org.deegree.tools.rendering.dem.builder.dag.DAGBuilder$DAGLevel.level | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Synchronization on interned String in org.deegree.tools.rendering.dem.filtering.DEMRasterFilterer.applyFilter() | MT_CORRECTNESS | DL_SYNCHRONIZATION_ON_SHARED_CONSTANT | 204 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.deegree.tools.rendering.dem.filtering.DEMRasterFilterer$FilteredResultWiter be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 576 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.deegree.tools.rendering.dem.filtering.DEMRasterFilterer$RasterComparator be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 527 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.deegree.tools.rendering.dem.filtering.DEMRasterFilterer$RasterFilterer be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 482 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to mean in org.deegree.tools.rendering.dem.filtering.filters.SmoothingFilter.calcKernelStdev(RasterData) | STYLE | DLS_DEAD_LOCAL_STORE | 251 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to hostURL in org.deegree.tools.rendering.manager.DataManager.getModelBackend(CommandLine) | STYLE | DLS_DEAD_LOCAL_STORE | 307 | Medium |
| Dead store to textureDir in org.deegree.tools.rendering.manager.DataManager.startManager(CommandLine) | STYLE | DLS_DEAD_LOCAL_STORE | 272 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.deegree.tools.rendering.manager.buildings.generalisation.WorldObjectSimplifier$RegressionForm be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 321 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of normals, which is known to be non-null in org.deegree.tools.rendering.manager.buildings.importers.VRMLImporter.importShape3D(RenderableQualityModel, Shape3D, Transform3D, double[], double[]) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 536 | Medium |
| exceptional return value of java.io.File.mkdir() ignored in new org.deegree.tools.rendering.manager.buildings.importers.VRMLImporter(Map) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 186 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.deegree.tools.rendering.manager.stage.StageManager.importFromFile(File, CommandLine): new java.io.FileReader(File) | I18N | DM_DEFAULT_ENCODING | 183 | High |
| Found reliance on default encoding in org.deegree.tools.rendering.manager.stage.StageManager.importFromFile(File, CommandLine): new java.io.FileWriter(File) | I18N | DM_DEFAULT_ENCODING | 200 | High |
| Found reliance on default encoding in org.deegree.tools.rendering.manager.stage.StageManager.readAndImportStages(CSVReader, Map, int): new java.io.FileWriter(File) | I18N | DM_DEFAULT_ENCODING | 222 | High |
| org.deegree.tools.rendering.manager.stage.StageManager.importFromFile(File, CommandLine) may fail to clean up java.io.Writer on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 200 | Medium |
| org.deegree.tools.rendering.manager.stage.StageManager.readAndImportStages(CSVReader, Map, int) may fail to clean up java.io.Writer on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 222 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.deegree.tools.rendering.manager.trees.TreeManager.importFromFile(File, CommandLine): new java.io.FileReader(File) | I18N | DM_DEFAULT_ENCODING | 164 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to tmpExporter in org.deegree.tools.rendering.viewer.Export3DFile.exportBranchgroup(MemoryAware) | STYLE | DLS_DEAD_LOCAL_STORE | 229 | Medium |
| Redundant nullcheck of org.deegree.tools.rendering.viewer.Export3DFile.selectedExporter which is known to be null in org.deegree.tools.rendering.viewer.Export3DFile.exportBranchgroup(MemoryAware) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 210 | Medium |
| org.deegree.tools.rendering.viewer.Export3DFile.createParameterDialog(J3DExporter) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 293 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.deegree.tools.rendering.viewer.File3dExporter.save(GLViewer, WorldRenderableObject): new java.io.FileWriter(File) | I18N | DM_DEFAULT_ENCODING | 93 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.tools.rendering.viewer.File3dImporter.gm isn't final and can't be protected from malicious code | MALICIOUS_CODE | MS_CANNOT_BE_FINAL | Medium |
