deegree-services-wpvs - FindBugs Bug Detector Report

Last Published: 2013-05-14 | Version: 3.3.0

deegree-services-wpvs

Parent Project

deegree-services

Project Documentation

Project Information
Project Reports
- FindBugs Report
- PMD Report
- CPD Report
- Checkstyle
- module stability status report

Built by Maven

FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 2.0.1

Threshold is medium

Effort is min

Summary

Classes	Bugs	Errors	Missing Classes
74	37	0	0

Files

Class	Bugs
org.deegree.services.wpvs.PerspectiveViewService	1
org.deegree.services.wpvs.config.DEMDataset	3
org.deegree.services.wpvs.io.DataObjectInfo	2
org.deegree.services.wpvs.io.ModelBackend	2
org.deegree.services.wpvs.io.db.DBBackend	18
org.deegree.services.wpvs.io.file.DataFile	1
org.deegree.services.wpvs.io.file.FileBackend	1
org.deegree.services.wpvs.io.file.IndexFile	1
org.deegree.services.wpvs.io.file.IndexFile$PositionBlob	1
org.deegree.services.wpvs.io.file.ModelFile	2
org.deegree.services.wpvs.io.serializer.ObjectSerializer	3
org.deegree.services.wpvs.rendering.jogl.ConfiguredOpenGLInitValues	2

org.deegree.services.wpvs.PerspectiveViewService

Bug	Category	Details	Line	Priority
org.deegree.services.wpvs.PerspectiveViewService.getTranslationVector() may expose internal representation by returning PerspectiveViewService.translationToLocalCRS	MALICIOUS_CODE	EI_EXPOSE_REP	545	Medium

org.deegree.services.wpvs.config.DEMDataset

Bug	Category	Details	Line	Priority
new org.deegree.services.wpvs.config.DEMDataset(int, int, float[], float[], float[], float) may expose internal representation by storing an externally mutable object into DEMDataset.ambientColor	MALICIOUS_CODE	EI_EXPOSE_REP2	94	Medium
new org.deegree.services.wpvs.config.DEMDataset(int, int, float[], float[], float[], float) may expose internal representation by storing an externally mutable object into DEMDataset.diffuseColor	MALICIOUS_CODE	EI_EXPOSE_REP2	95	Medium
new org.deegree.services.wpvs.config.DEMDataset(int, int, float[], float[], float[], float) may expose internal representation by storing an externally mutable object into DEMDataset.specularColor	MALICIOUS_CODE	EI_EXPOSE_REP2	96	Medium

org.deegree.services.wpvs.io.DataObjectInfo

Bug	Category	Details	Line	Priority
org.deegree.services.wpvs.io.DataObjectInfo.getSerializedData() may expose internal representation by returning DataObjectInfo.serializedData	MALICIOUS_CODE	EI_EXPOSE_REP	160	Medium
org.deegree.services.wpvs.io.DataObjectInfo.setSerializedData(byte[]) may expose internal representation by storing an externally mutable object into DataObjectInfo.serializedData	MALICIOUS_CODE	EI_EXPOSE_REP2	168	Medium

org.deegree.services.wpvs.io.ModelBackend

Bug	Category	Details	Line	Priority
org.deegree.services.wpvs.io.ModelBackend.getWPVSTranslationVector() may expose internal representation by returning ModelBackend.wpvsTranslationVector	MALICIOUS_CODE	EI_EXPOSE_REP	351	Medium
org.deegree.services.wpvs.io.ModelBackend.setWPVSTranslationVector(double[]) may expose internal representation by storing an externally mutable object into ModelBackend.wpvsTranslationVector	MALICIOUS_CODE	EI_EXPOSE_REP2	359	Medium

org.deegree.services.wpvs.io.db.DBBackend

Bug	Category	Details	Line	Priority
org.deegree.services.wpvs.io.db.DBBackend.deleteObjectsFromDB(ModelBackend$Type, String) may fail to clean up java.sql.Statement	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION	531	Medium
org.deegree.services.wpvs.io.db.DBBackend.getDeSerializedObjectsForSQL(ModelBackend$Type, String) may fail to clean up java.sql.ResultSet	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION	368	Medium
org.deegree.services.wpvs.io.db.DBBackend.getDeSerializedObjectsForSQL(ModelBackend$Type, String) may fail to clean up java.sql.Statement	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION	367	Medium
org.deegree.services.wpvs.io.db.DBBackend.getRenderableObjects(String, Collection, ObjectSerializer) may fail to clean up java.sql.Statement	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION	916	Medium
org.deegree.services.wpvs.io.db.DBBackend.updateWRO(ModelBackend$Type, int, String) may fail to clean up java.sql.ResultSet	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION	458	Medium
org.deegree.services.wpvs.io.db.DBBackend.updateWRO(ModelBackend$Type, int, String) may fail to clean up java.sql.Statement	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION	454	Medium
org.deegree.services.wpvs.io.db.DBBackend.doInsert(DataObjectInfo, Connection, String) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	743	Medium
org.deegree.services.wpvs.io.db.DBBackend.doUpdate(DataObjectInfo, Connection, String) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	768	Medium
org.deegree.services.wpvs.io.db.DBBackend.getDeSerializedObjectForUUID(Connection, ModelBackend$Type, String) may fail to clean up java.sql.ResultSet on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	396	Medium
org.deegree.services.wpvs.io.db.DBBackend.getDeSerializedObjectForUUID(Connection, ModelBackend$Type, String) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	394	Medium
org.deegree.services.wpvs.io.db.DBBackend.getResultSet(Connection, String, String) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	985	Medium
org.deegree.services.wpvs.io.db.DBBackend.shouldUpdate(Connection, String, String) may fail to clean up java.sql.ResultSet on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	796	Medium
org.deegree.services.wpvs.io.db.DBBackend.shouldUpdate(Connection, String, String) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	793	Medium
org.deegree.services.wpvs.io.db.DBBackend.deleteObjectsFromDB(ModelBackend$Type, String) may fail to close PreparedStatement	BAD_PRACTICE	ODR_OPEN_DATABASE_RESOURCE	531	Medium
org.deegree.services.wpvs.io.db.DBBackend.getDeSerializedObjectsForSQL(ModelBackend$Type, String) may fail to close PreparedStatement	BAD_PRACTICE	ODR_OPEN_DATABASE_RESOURCE	367	Medium
org.deegree.services.wpvs.io.db.DBBackend.getRenderableObjects(String, Collection, ObjectSerializer) may fail to close PreparedStatement	BAD_PRACTICE	ODR_OPEN_DATABASE_RESOURCE	916	Medium
org.deegree.services.wpvs.io.db.DBBackend.updateWRO(ModelBackend$Type, int, String) may fail to close PreparedStatement	BAD_PRACTICE	ODR_OPEN_DATABASE_RESOURCE	454	Medium
Redundant nullcheck of tree, which is known to be non-null in org.deegree.services.wpvs.io.db.DBBackend.loadTrees(TreeRenderer, ICRS)	STYLE	RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE	323	Medium

org.deegree.services.wpvs.io.file.DataFile

Bug	Category	Details	Line	Priority
exceptional return value of java.io.File.createNewFile() ignored in org.deegree.services.wpvs.io.file.DataFile.close()	BAD_PRACTICE	RV_RETURN_VALUE_IGNORED_BAD_PRACTICE	255	Medium

org.deegree.services.wpvs.io.file.FileBackend

Bug	Category	Details	Line	Priority
exceptional return value of java.io.File.createNewFile() ignored in org.deegree.services.wpvs.io.file.FileBackend.initFiles(File)	BAD_PRACTICE	RV_RETURN_VALUE_IGNORED_BAD_PRACTICE	380	Medium

org.deegree.services.wpvs.io.file.IndexFile

Bug	Category	Details	Line	Priority
exceptional return value of java.io.File.createNewFile() ignored in org.deegree.services.wpvs.io.file.IndexFile.close()	BAD_PRACTICE	RV_RETURN_VALUE_IGNORED_BAD_PRACTICE	165	Medium

org.deegree.services.wpvs.io.file.IndexFile$PositionBlob

Bug	Category	Details	Line	Priority
org.deegree.services.wpvs.io.file.IndexFile$PositionBlob defines equals and uses Object.hashCode()	BAD_PRACTICE	HE_EQUALS_USE_HASHCODE	245	Medium

org.deegree.services.wpvs.io.file.ModelFile

Bug	Category	Details	Line	Priority
Redundant nullcheck of fromFile, which is known to be non-null in org.deegree.services.wpvs.io.file.ModelFile.readAllFromFile(ICRS)	STYLE	RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE	278	Medium
exceptional return value of java.io.File.createNewFile() ignored in org.deegree.services.wpvs.io.file.ModelFile.writeBackendInfo()	BAD_PRACTICE	RV_RETURN_VALUE_IGNORED_BAD_PRACTICE	218	Medium

org.deegree.services.wpvs.io.serializer.ObjectSerializer

Bug	Category	Details	Line	Priority
Found reliance on default encoding in org.deegree.services.wpvs.io.serializer.ObjectSerializer.readString(ByteBuffer): new String(byte[])	I18N	DM_DEFAULT_ENCODING	243	High
Found reliance on default encoding in org.deegree.services.wpvs.io.serializer.ObjectSerializer.sizeOfString(String): String.getBytes()	I18N	DM_DEFAULT_ENCODING	259	High
Found reliance on default encoding in org.deegree.services.wpvs.io.serializer.ObjectSerializer.writeString(ByteBuffer, String): String.getBytes()	I18N	DM_DEFAULT_ENCODING	223	High

org.deegree.services.wpvs.rendering.jogl.ConfiguredOpenGLInitValues

Bug	Category	Details	Line	Priority
Synchronization on interned String in org.deegree.services.wpvs.rendering.jogl.ConfiguredOpenGLInitValues.createCompositingTextureShaderPrograms(GL)	MT_CORRECTNESS	DL_SYNCHRONIZATION_ON_SHARED_CONSTANT	126	Medium
org.deegree.services.wpvs.rendering.jogl.ConfiguredOpenGLInitValues.getCompositingTextureShaderPrograms() may expose internal representation by returning ConfiguredOpenGLInitValues.compositeTextureShaderPrograms	MALICIOUS_CODE	EI_EXPOSE_REP	153	Medium