The following document contains the results of FindBugs Report
FindBugs Version is 2.0.1
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Switch statement found in org.deegree.feature.persistence.mapping.antlr.FMLLexer.mIdentifier() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 134 | Medium |
| Switch statement found in org.deegree.feature.persistence.mapping.antlr.FMLLexer.mTokens() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 445 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.feature.persistence.mapping.antlr.FMLParser.getTokenNames() may expose internal representation by returning FMLParser.tokenNames | MALICIOUS_CODE | EI_EXPOSE_REP | 57 | Medium |
| org.deegree.feature.persistence.mapping.antlr.FMLParser.tokenNames should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 21 | Medium |
| Possible null pointer dereference of null in org.deegree.feature.persistence.mapping.antlr.FMLParser.stringConst() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 294 | Medium |
| Redundant nullcheck of ma, which is known to be non-null in org.deegree.feature.persistence.mapping.antlr.FMLParser.function() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 398 | Medium |
| Redundant nullcheck of ma2, which is known to be non-null in org.deegree.feature.persistence.mapping.antlr.FMLParser.function() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 434 | Medium |
| Redundant nullcheck of dbField2, which is known to be non-null in org.deegree.feature.persistence.mapping.antlr.FMLParser.mappingExpr() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 199 | Medium |
| Redundant nullcheck of stringConst4, which is known to be non-null in org.deegree.feature.persistence.mapping.antlr.FMLParser.mappingExpr() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 233 | Medium |
| Nullcheck of function3 at line 214 of value previously dereferenced in org.deegree.feature.persistence.mapping.antlr.FMLParser.mappingExpr() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 214 | High |
| Switch statement found in org.deegree.feature.persistence.mapping.antlr.FMLParser.dbField() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 581 | Medium |
| Switch statement found in org.deegree.feature.persistence.mapping.antlr.FMLParser.function() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 375 | Medium |
| Switch statement found in org.deegree.feature.persistence.mapping.antlr.FMLParser.mappingExpr() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 185 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.deegree.feature.persistence.sql.MappedAppSchema(FeatureType[], Map, Map, GMLSchemaInfoSet, FeatureTypeMapping[], BBoxTableMapping, BlobMapping, GeometryStorageParams, boolean, RelationalModel, List, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 144 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of org.deegree.feature.persistence.sql.jaxb.SQLFeatureStoreJAXB$JDBCConnId.getFetchSize(), which is known to be non-null in new org.deegree.feature.persistence.sql.SQLFeatureStore(SQLFeatureStoreJAXB, URL, SQLDialect) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 211 | Medium |
| Exception is caught when Exception is not thrown in org.deegree.feature.persistence.sql.SQLFeatureStore.queryByOperatorFilter(Query, QName, OperatorFilter) | STYLE | REC_CATCH_EXCEPTION | 1422 | Medium |
| Exception is caught when Exception is not thrown in org.deegree.feature.persistence.sql.SQLFeatureStore.queryByOperatorFilterBlob(Query, QName, OperatorFilter) | STYLE | REC_CATCH_EXCEPTION | 1307 | Medium |
| Exception is caught when Exception is not thrown in org.deegree.feature.persistence.sql.SQLFeatureStore.queryHitsByOperatorFilter(Query, QName, OperatorFilter) | STYLE | REC_CATCH_EXCEPTION | 811 | Medium |
| Exception is caught when Exception is not thrown in org.deegree.feature.persistence.sql.SQLFeatureStore.queryHitsByOperatorFilterBlob(Query, QName, OperatorFilter) | STYLE | REC_CATCH_EXCEPTION | 876 | Medium |
| Exception is caught when Exception is not thrown in org.deegree.feature.persistence.sql.SQLFeatureStore.queryMultipleFts(Query[], Envelope) | STYLE | REC_CATCH_EXCEPTION | 1499 | Medium |
| org.deegree.feature.persistence.sql.SQLFeatureStore.calcEnvelope(FeatureTypeMapping, Connection) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 504 | High |
| A prepared statement is generated from a nonconstant String in org.deegree.feature.persistence.sql.SQLFeatureStore.queryByOperatorFilter(Query, QName, OperatorFilter) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 1401 | High |
| A prepared statement is generated from a nonconstant String in org.deegree.feature.persistence.sql.SQLFeatureStore.queryHitsByOperatorFilter(Query, QName, OperatorFilter) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 795 | High |
| A prepared statement is generated from a nonconstant String in org.deegree.feature.persistence.sql.SQLFeatureStore.queryMultipleFts(Query[], Envelope) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 1478 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.deegree.feature.persistence.sql.SQLFeatureStore$FeatureResultSetIterator be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 1545 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.feature.persistence.sql.SQLFeatureStoreTransaction.deleteJoinedRows(Mapping, Map) may fail to clean up java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 468 | Medium |
| org.deegree.feature.persistence.sql.SQLFeatureStoreTransaction.performInsert(FeatureCollection, IDGenMode) may fail to clean up java.sql.Statement on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 627 | Medium |
| A prepared statement is generated from a nonconstant String in org.deegree.feature.persistence.sql.SQLFeatureStoreTransaction.performInsert(FeatureCollection, IDGenMode) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 627 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.feature.persistence.sql.blob.BlobCodec.encode(GMLObject, Map, OutputStream, ICRS) may fail to clean up java.io.OutputStream on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 155 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.deegree.feature.persistence.sql.config.ColumnMetadata.sqlTypeName | PERFORMANCE | URF_UNREAD_FIELD | 602 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.deegree.feature.persistence.sql.config.ColumnMetadataOld.sqlTypeName | PERFORMANCE | URF_UNREAD_FIELD | 588 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.feature.persistence.sql.config.MappedSchemaBuilderGML.addNamespaceBindings(String, AppSchema, List) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 233 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.feature.persistence.sql.config.MappedSchemaBuilderTable.getColumns(TableName) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 501 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of org.deegree.feature.persistence.sql.jaxb.GeometryPropertyJAXB.getDim(), which is known to be non-null in org.deegree.feature.persistence.sql.config.MappedSchemaBuilderTableOld.process(TableName, AbstractPropertyJAXB) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 354 | Medium |
| org.deegree.feature.persistence.sql.config.MappedSchemaBuilderTableOld.getColumns(TableName) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 487 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to schema in org.deegree.feature.persistence.sql.ddl.OracleDDLCreator.getGeometryCreate(GeometryMapping, DBField, TableName) | STYLE | DLS_DEAD_LOCAL_STORE | 128 | Medium |
| Dead store to srid in org.deegree.feature.persistence.sql.ddl.OracleDDLCreator.getGeometryCreate(GeometryMapping, DBField, TableName) | STYLE | DLS_DEAD_LOCAL_STORE | 130 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.feature.persistence.sql.expressions.Function.toString() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 75 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Invocation of toString on IdAnalysis.idKernels in org.deegree.feature.persistence.sql.id.IdAnalysis.toString() | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 92 | High |
| org.deegree.feature.persistence.sql.id.IdAnalysis.getIdKernels() may expose internal representation by returning IdAnalysis.idKernels | MALICIOUS_CODE | EI_EXPOSE_REP | 80 | Medium |
| Unread field: org.deegree.feature.persistence.sql.id.IdAnalysis.isFid; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 54 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.feature.persistence.sql.insert.FeatureRow.buildNewFid() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 220 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.feature.persistence.sql.insert.InsertRow.performInsert(Connection, boolean) may fail to clean up java.sql.Statement on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 202 | Medium |
| org.deegree.feature.persistence.sql.insert.InsertRow.generateImmediateKeys(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 97 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of ftJoin, which is known to be non-null in org.deegree.feature.persistence.sql.mapper.AppSchemaMapper.generatePropMapping(FeaturePropertyType, MappingContext) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 407 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.feature.persistence.sql.rules.CompoundMapping.toString() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 78 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all nonnull values in org.deegree.feature.persistence.sql.rules.FeatureBuilderRelational.buildParticle(Mapping, ResultSet, LinkedHashMap, String), since all org.deegree.commons.tom.genericxml.GenericXMLElement are instances of org.deegree.commons.tom.genericxml.GenericXMLElement | STYLE | BC_VACUOUS_INSTANCEOF | 533 | Medium |
| org.deegree.feature.persistence.sql.rules.FeatureBuilderRelational.getJoinedResultSet(TableJoin, Mapping, ResultSet, LinkedHashMap) may fail to clean up java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 700 | Medium |
| org.deegree.feature.persistence.sql.rules.FeatureBuilderRelational.getJoinedResultSet(TableJoin, Mapping, ResultSet, LinkedHashMap) may fail to clean up java.sql.Statement | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 690 | Medium |
| A prepared statement is generated from a nonconstant String in org.deegree.feature.persistence.sql.rules.FeatureBuilderRelational.getJoinedResultSet(TableJoin, Mapping, ResultSet, LinkedHashMap) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 690 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.feature.persistence.sql.xpath.AttrStep defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 56 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.feature.persistence.sql.xpath.ElementStep defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 67 | Medium |
