The following document contains the results of FindBugs Report
FindBugs Version is 2.0.1
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.protocol.wfs.describefeaturetype.DescribeFeatureType.getTypeNames() may expose internal representation by returning DescribeFeatureType.typeNames | MALICIOUS_CODE | EI_EXPOSE_REP | 107 | Medium |
| new org.deegree.protocol.wfs.describefeaturetype.DescribeFeatureType(Version, String, String, QName[], Map) may expose internal representation by storing an externally mutable object into DescribeFeatureType.typeNames | MALICIOUS_CODE | EI_EXPOSE_REP2 | 88 | Medium |
| org.deegree.protocol.wfs.describefeaturetype.DescribeFeatureType.toString() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 129 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Comparison of String objects using == or != in org.deegree.protocol.wfs.describefeaturetype.kvp.DescribeFeatureTypeKVPAdapter.augmentNsBindings(Map, QName[]) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 272 | Medium |
| Comparison of String objects using == or != in org.deegree.protocol.wfs.describefeaturetype.kvp.DescribeFeatureTypeKVPAdapter.export(DescribeFeatureType, Version) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 215 | Medium |
| org.deegree.protocol.wfs.describefeaturetype.kvp.DescribeFeatureTypeKVPAdapter.export(DescribeFeatureType, Version) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 230 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.protocol.wfs.getfeature.kvp.GetFeatureKVPAdapter.parse100(Map, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 133 | Medium |
| org.deegree.protocol.wfs.getfeature.kvp.GetFeatureKVPAdapter.parse110(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 278 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all nonnull values in org.deegree.protocol.wfs.getfeature.xml.GetFeature110XMLEncoder.writePropertyNameCharacters(ValueReference, XMLStreamWriter), since all org.deegree.commons.xml.NamespaceBindings are instances of org.deegree.commons.xml.NamespaceBindings | STYLE | BC_VACUOUS_INSTANCEOF | 342 | Medium |
| Redundant nullcheck of projectionClause, which is known to be non-null in org.deegree.protocol.wfs.getfeature.xml.GetFeature110XMLEncoder.export(FilterQuery, XMLStreamWriter) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 237 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.protocol.wfs.getpropertyvalue.kvp.GetPropertyValueKVPAdapter.parse200(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 114 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of typeNames, which is known to be non-null in org.deegree.protocol.wfs.lockfeature.kvp.LockFeatureKVPAdapter.parse110(Map) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 193 | Medium |
| org.deegree.protocol.wfs.lockfeature.kvp.LockFeatureKVPAdapter.parse110(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 134 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.protocol.wfs.query.AdHocQuery.getProjectionClauses() may expose internal representation by returning AdHocQuery.projectionClauses | MALICIOUS_CODE | EI_EXPOSE_REP | 134 | Medium |
| org.deegree.protocol.wfs.query.AdHocQuery.getSortBy() may expose internal representation by returning AdHocQuery.sortBy | MALICIOUS_CODE | EI_EXPOSE_REP | 143 | Medium |
| org.deegree.protocol.wfs.query.AdHocQuery.getTypeNames() may expose internal representation by returning AdHocQuery.typeNames | MALICIOUS_CODE | EI_EXPOSE_REP | 107 | Medium |
| new org.deegree.protocol.wfs.query.AdHocQuery(String, TypeName[], String, ICRS, ProjectionClause[], SortProperty[]) may expose internal representation by storing an externally mutable object into AdHocQuery.projectionClauses | MALICIOUS_CODE | EI_EXPOSE_REP2 | 90 | Medium |
| new org.deegree.protocol.wfs.query.AdHocQuery(String, TypeName[], String, ICRS, ProjectionClause[], SortProperty[]) may expose internal representation by storing an externally mutable object into AdHocQuery.sortBy | MALICIOUS_CODE | EI_EXPOSE_REP2 | 95 | Medium |
| new org.deegree.protocol.wfs.query.AdHocQuery(String, TypeName[], String, ICRS, ProjectionClause[], SortProperty[]) may expose internal representation by storing an externally mutable object into AdHocQuery.typeNames | MALICIOUS_CODE | EI_EXPOSE_REP2 | 85 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.protocol.wfs.query.FeatureIdQuery.getFeatureIds() may expose internal representation by returning FeatureIdQuery.featureIds | MALICIOUS_CODE | EI_EXPOSE_REP | 91 | Medium |
| new org.deegree.protocol.wfs.query.FeatureIdQuery(String, TypeName[], String, ICRS, PropertyName[], SortProperty[], String[]) may expose internal representation by storing an externally mutable object into FeatureIdQuery.featureIds | MALICIOUS_CODE | EI_EXPOSE_REP2 | 82 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of ptxDepthAr in org.deegree.protocol.wfs.query.kvp.QueryKVPAdapter.getXLinkPropNames(PropertyName[][], String[][], Integer[][]) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 553 | Medium |
| org.deegree.protocol.wfs.query.kvp.QueryKVPAdapter.parseAdhocQueries200(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 210 | Medium |
| org.deegree.protocol.wfs.query.kvp.QueryKVPAdapter.parseStoredQuery200(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 491 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.protocol.wfs.storedquery.DescribeStoredQueries.getStoredQueryIds() may expose internal representation by returning DescribeStoredQueries.storedQueryIds | MALICIOUS_CODE | EI_EXPOSE_REP | 84 | Medium |
| new org.deegree.protocol.wfs.storedquery.DescribeStoredQueries(Version, String, String[]) may expose internal representation by storing an externally mutable object into DescribeStoredQueries.storedQueryIds | MALICIOUS_CODE | EI_EXPOSE_REP2 | 74 | Medium |
