FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 2.0.1

Threshold is medium

Effort is min

Summary

ClassesBugsErrorsMissing Classes
421205

org.deegree.client.core.debug.ParameterPhaseListener

BugCategoryDetailsLinePriority
org.deegree.client.core.debug.ParameterPhaseListener.beforePhase(PhaseEvent) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR75Medium

org.deegree.client.core.renderer.InputBBoxRenderer

BugCategoryDetailsLinePriority
Redundant nullcheck of crsText, which is known to be non-null in org.deegree.client.core.renderer.InputBBoxRenderer.encodeCRSSelect(ResponseWriter, HtmlInputBBox, String, FacesContext, boolean)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE164Medium
org.deegree.client.core.renderer.InputBBoxRenderer.decode(FacesContext, UIComponent) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR107Medium

org.deegree.client.core.renderer.InputMultipleTextRenderer

BugCategoryDetailsLinePriority
org.deegree.client.core.renderer.InputMultipleTextRenderer.decode(FacesContext, UIComponent) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR74Medium

org.deegree.client.core.renderer.OutputXMLRenderer

BugCategoryDetailsLinePriority
org.deegree.client.core.renderer.OutputXMLRenderer.encodeDownload(ResponseWriter, HtmlOutputXML) may fail to clean up java.io.InputStream on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE113Medium
exceptional return value of java.io.File.delete() ignored in org.deegree.client.core.renderer.OutputXMLRenderer.encodeDownload(ResponseWriter, HtmlOutputXML)BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE120Medium
exceptional return value of java.io.File.mkdirs() ignored in org.deegree.client.core.renderer.OutputXMLRenderer.encodeDownload(ResponseWriter, HtmlOutputXML)BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE107Medium

org.deegree.client.core.renderer.OutputXMLRenderer$DeleteThread

BugCategoryDetailsLinePriority
Should org.deegree.client.core.renderer.OutputXMLRenderer$DeleteThread be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC325Medium

org.deegree.client.core.utils.JavaScriptUtils

BugCategoryDetailsLinePriority
org.deegree.client.core.utils.JavaScriptUtils.getAjaxRequest(Map, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR60Medium

org.deegree.client.core.utils.SQLExecution

BugCategoryDetailsLinePriority
new org.deegree.client.core.utils.SQLExecution(String, String[], String, DeegreeWorkspace) may expose internal representation by storing an externally mutable object into SQLExecution.sqlStatementsMALICIOUS_CODEEI_EXPOSE_REP275Medium
org.deegree.client.core.utils.SQLExecution.execute() may fail to clean up java.sql.StatementEXPERIMENTALOBL_UNSATISFIED_OBLIGATION112Medium
Class org.deegree.client.core.utils.SQLExecution defines non-transient non-serializable instance field workspaceBAD_PRACTICESE_BAD_FIELDHigh