The following document contains the results of FindBugs Report
FindBugs Version is 2.0.1
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.client.i18n.Messages.<static initializer>() may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 84 | Medium |
| org.deegree.client.i18n.Messages.overrideMessages(String, Properties) may fail to clean up java.io.InputStream on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 113 | Medium |
| org.deegree.client.i18n.Messages.<static initializer>() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 84 | Medium |
| org.deegree.client.i18n.Messages.overrideMessages(String, Properties) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 122 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.deegree.client.sos.SOSClient defines non-transient non-serializable instance field observationStorages | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to result in org.deegree.client.sos.requesthandler.HandleDescribeSensor.parseCapabilities() | STYLE | DLS_DEAD_LOCAL_STORE | 188 | Medium |
| Dead store to result in org.deegree.client.sos.requesthandler.HandleDescribeSensor.parseCharacteristics() | STYLE | DLS_DEAD_LOCAL_STORE | 198 | Medium |
| Dead store to result in org.deegree.client.sos.requesthandler.HandleDescribeSensor.parseClassification() | STYLE | DLS_DEAD_LOCAL_STORE | 208 | Medium |
| Dead store to result in org.deegree.client.sos.requesthandler.HandleDescribeSensor.parseContact() | STYLE | DLS_DEAD_LOCAL_STORE | 218 | Medium |
| Dead store to result in org.deegree.client.sos.requesthandler.HandleDescribeSensor.parseDocumentation() | STYLE | DLS_DEAD_LOCAL_STORE | 228 | Medium |
| Dead store to result in org.deegree.client.sos.requesthandler.HandleDescribeSensor.parseHistory() | STYLE | DLS_DEAD_LOCAL_STORE | 238 | Medium |
| Dead store to result in org.deegree.client.sos.requesthandler.HandleDescribeSensor.parseIdentification() | STYLE | DLS_DEAD_LOCAL_STORE | 248 | Medium |
| Dead store to result in org.deegree.client.sos.requesthandler.HandleDescribeSensor.parseKeywords() | STYLE | DLS_DEAD_LOCAL_STORE | 258 | Medium |
| Dead store to result in org.deegree.client.sos.requesthandler.HandleDescribeSensor.parseLegalConstraint() | STYLE | DLS_DEAD_LOCAL_STORE | 268 | Medium |
| Dead store to result in org.deegree.client.sos.requesthandler.HandleDescribeSensor.parseMember() | STYLE | DLS_DEAD_LOCAL_STORE | 278 | Medium |
| Dead store to result in org.deegree.client.sos.requesthandler.HandleDescribeSensor.parseSecurityConstraint() | STYLE | DLS_DEAD_LOCAL_STORE | 288 | Medium |
| Dead store to result in org.deegree.client.sos.requesthandler.HandleDescribeSensor.parseValidTime() | STYLE | DLS_DEAD_LOCAL_STORE | 298 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.client.sos.requesthandler.HandleGetObservation.buildRequest(String, Map) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 139 | Medium |
| org.deegree.client.sos.requesthandler.HandleGetObservation.parseFeatureOfInterest(OMElement) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 317 | Medium |
| org.deegree.client.sos.requesthandler.HandleGetObservation.parseProcedure(OMElement) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 365 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of procedure at line 69 of value previously dereferenced in org.deegree.client.sos.requesthandler.kvp.GetKVPDescribeSensor.parseProcedure(List) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 69 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of procedure at line 96 of value previously dereferenced in org.deegree.client.sos.requesthandler.kvp.GetKVPGetObservation.parseOffering(List) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 96 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.deegree.client.sos.storage.ChartInput.getDates() may expose internal representation by returning ChartInput.dates | MALICIOUS_CODE | EI_EXPOSE_REP | 47 | Medium |
| org.deegree.client.sos.storage.ChartInput.setDates(Date[]) may expose internal representation by storing an externally mutable object into ChartInput.dates | MALICIOUS_CODE | EI_EXPOSE_REP2 | 79 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.deegree.client.sos.storage.components.OWSException is not derived from an Exception, even though it is named as such | BAD_PRACTICE | NM_CLASS_NOT_EXCEPTION | 12 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.deegree.client.sos.utils.ChartProcessing.createXYDataset(ChartInput) | STYLE | REC_CATCH_EXCEPTION | 103 | Medium |
